Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import moment for es locale #28948

Merged
merged 1 commit into from
Oct 6, 2023
Merged

import moment for es locale #28948

merged 1 commit into from
Oct 6, 2023

Conversation

mkhutornyi
Copy link
Contributor

@mkhutornyi mkhutornyi commented Oct 5, 2023 •
edited by github-actions bot
Loading

Details

fix crash on date picker page

Fixed Issues

$ #28315
PROPOSAL: #26719 (comment)

Tests

Same as QA step

  • Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

  1. Go to Settings > Preferences > Language > choose Spanish
  2. Go to FAB > Request money > select Distance tab
  3. Enter start and finish addresses and click Next
  4. Select any participant
  5. On confirmation page, click Date field
  6. Verify that Date picker page shows without crash
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mchrome.mov
Mobile Web - Safari
msafari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov

@mkhutornyi mkhutornyi requested a review from a team as a code owner October 5, 2023 18:56
@melvin-bot melvin-bot bot requested review from situchan and removed request for a team October 5, 2023 18:56
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan
Copy link
Contributor

situchan commented Oct 6, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mchrome.mov
Mobile Web - Safari
msafari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov

neil-marcellini
neil-marcellini approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@neil-marcellini neil-marcellini merged commit 6682740 into Expensify:main Oct 6, 2023
16 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1202.649 ms → 1289.986 ms (+87.337 ms, +7.3%) 🔴
App start runJsBundle 824.253 ms → 888.511 ms (+64.258 ms, +7.8%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1202.649 ms
Stdev: 39.271 ms (3.3%)
Runs: 1127.0495400000364 1129.6586729995906 1130.972881000489 1131.1109759993851 1137.1095649991184 1144.247239999473 1145.7931670006365 1147.6218560002744 1149.9954029992223 1150.6717360001057 1152.1729129999876 1153.8626230005175 1156.9012960009277 1159.7112649995834 1161.1161579992622 1161.4373560007662 1162.8145669996738 1168.1625730004162 1168.5792890004814 1169.8147400002927 1170.2421530000865 1172.2672489993274 1172.7293640002608 1173.2538699992 1174.1034200005233 1175.9038570001721 1178.578274000436 1180.289653999731 1182.8290079999715 1183.255914999172 1184.0859319996089 1185.6407779995352 1186.706222999841 1187.0190190002322 1187.1998730003834 1187.4865739997476 1188.170678999275 1188.252932999283 1190.3207590002567 1191.0907809995115 1193.6786809992045 1194.0773109998554 1197.445931000635 1200.7882039994001 1201.9443570002913 1203.6988469995558 1203.7851890008897 1206.574645999819 1207.804764000699 1208.627655999735 1209.1689589992166 1209.592929000035 1209.6891159992665 1211.0298670008779 1211.876779999584 1213.4502329993993 1216.1313189994544 1218.8937410004437 1219.703683000058 1222.6044999994338 1223.6346480008215 1225.0408399999142 1226.7632100004703 1227.2612650003284 1227.352855000645 1233.251666000113 1233.514978999272 1233.551147999242 1234.6610359996557 1234.971496000886 1236.1695799995214 1236.616372000426 1237.0394449997693 1238.0683629997075 1238.725747000426 1239.709417000413 1239.881800999865 1240.4073200002313 1243.6217139996588 1243.9814379997551 1245.5972000006586 1246.4908579997718 1253.9338450003415 1255.1997449994087 1256.9148260001093 1264.6176939997822 1266.33882500045 1268.681608999148 1272.3794119991362 1297.446392999962 1310.4562359992415

Current
Mean: 1289.986 ms
Stdev: 50.136 ms (3.9%)
Runs: 1177.4649069998413 1205.549644999206 1207.5698729995638 1207.6972959991544 1214.3477469999343 1218.4310640003532 1221.9595439992845 1222.386366000399 1223.444339999929 1224.8253080006689 1230.0375440008938 1230.0838200002909 1230.2669740002602 1230.6488000005484 1232.1871089991182 1232.3803220000118 1236.1044079996645 1240.299538999796 1244.208218999207 1246.0380359999835 1249.4242749996483 1252.411329999566 1252.8955370001495 1257.2580740004778 1258.9851590003818 1259.712905999273 1259.7208469994366 1259.779639000073 1262.0948510002345 1264.5765480007976 1265.9939019996673 1268.2079119998962 1269.4293460007757 1270.7035189997405 1272.296330999583 1273.4247280005366 1274.121479999274 1274.4622370004654 1275.988987000659 1276.9961179997772 1277.2431760001928 1277.380869999528 1277.6392969992012 1277.99277699925 1280.3866739999503 1281.3036100007594 1281.503233000636 1283.8719609994441 1285.8815369997174 1289.6198120005429 1290.9493620004505 1292.3460980001837 1296.385067999363 1296.545106999576 1300.1356770005077 1302.6345220003277 1303.1648299992085 1303.3653510008007 1307.6558459997177 1308.335318999365 1309.5358499996364 1314.6689509991556 1315.575637999922 1319.0446479991078 1319.6453600004315 1320.0861389990896 1321.2531160004437 1321.3854239992797 1323.641630999744 1324.8059390001 1326.6496500000358 1326.7973590008914 1330.6338739991188 1338.2266520000994 1338.4763200003654 1344.9803509991616 1351.5730160009116 1354.4316230006516 1355.9852579999715 1356.7511870004237 1359.6847820002586 1360.8097109999508 1361.6761600002646 1366.0592780001462 1368.5314370002598 1369.3954930007458 1371.224605999887 1372.1745609994978 1372.565592000261 1372.7888730000705 1383.7367620002478 1417.1799010001123
App start runJsBundle Baseline
Mean: 824.253 ms
Stdev: 33.125 ms (4.0%)
Runs: 728 745 751 759 773 777 780 781 784 785 790 791 792 793 793 795 795 795 797 797 797 799 799 801 801 802 807 809 811 812 812 812 813 813 814 815 816 817 817 818 818 819 821 821 823 823 828 829 830 830 830 831 832 833 833 834 836 836 836 838 838 839 840 841 841 841 846 846 848 849 849 849 850 853 855 860 860 860 861 862 864 865 868 870 872 873 878 881 883 885 913

Current
Mean: 888.511 ms
Stdev: 36.595 ms (4.1%)
Runs: 805 820 824 832 838 838 840 842 842 843 845 846 848 849 850 850 853 853 854 858 859 860 860 860 863 863 865 865 865 868 872 872 872 873 873 875 876 877 877 878 878 879 882 883 885 887 888 889 890 892 892 893 893 895 896 899 900 900 902 903 903 904 906 907 907 907 909 910 914 915 915 915 917 921 921 921 924 925 928 930 931 931 939 940 940 949 949 951 955 965 982 983

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 632.444 ms → 635.081 ms (+2.637 ms, ±0.0%)
App start nativeLaunch 21.596 ms → 22.356 ms (+0.760 ms, +3.5%)
App start regularAppStart 0.015 ms → 0.017 ms (+0.002 ms, +16.3%) 🟡
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 632.444 ms
Stdev: 24.299 ms (3.8%)
Runs: 586.4449060000479 594.2196050006896 597.1890459991992 597.2776290010661 598.469482999295 602.3540860004723 603.1791590005159 604.9662280008197 605.078614000231 605.2286779992282 606.1087239999324 608.5577809996903 608.8662509992719 609.2240400016308 609.9077150002122 610.3745530005544 610.9201660007238 611.484864000231 612.8216960001737 613.7820229995996 614.3924570009112 614.6385099999607 614.7799080014229 614.9205729998648 615.4564619995654 615.5325120016932 618.0950929988176 618.4992270004004 619.4557699989527 619.6359049994498 620.0736490003765 620.7568359989673 621.2183839995414 621.3993739988655 621.8684490006417 622.0083419997245 622.0340979993343 622.1050619985908 624.5851640012115 625.7397869993001 626.4635419994593 626.6073410008103 626.6461190003902 626.8229569997638 627.7028809990734 627.9296470005065 628.1435139998794 629.046305000782 629.4075520001352 629.7128100004047 631.59444199875 634.4833169989288 635.9787600003183 636.0331219993532 637.671468000859 637.6909999996424 638.2723799999803 639.1560469996184 639.2938640005887 639.7217609994113 640.0944010000676 640.8898520004004 644.1216230001301 644.2304279990494 645.3052169997245 645.7134610004723 646.1922609992325 647.4778649993241 651.3435880001634 654.6991790011525 654.7432460002601 656.2840979993343 657.771891001612 658.2416580002755 661.2684329990298 661.2886959984899 661.3310960009694 661.6651610005647 663.7287600003183 665.9358729999512 667.0189619995654 669.7715259995311 671.6318360008299 675.3612879998982 676.4215909987688 694.7497969996184 697.1197919994593 708.6658120006323

Current
Mean: 635.081 ms
Stdev: 28.240 ms (4.4%)
Runs: 595.031860999763 596.4369309991598 596.7208660002798 597.1916499994695 601.5048829987645 601.5464679989964 601.6386320013553 601.8711749985814 602.6017659995705 603.0731610003859 605.5680350009352 607.2458100002259 608.6627200003713 609.4872639998794 610.5484619997442 610.7424319982529 610.9189449995756 611.8545329999179 612.9475500006229 613.2377519998699 614.1174730006605 614.9145109988749 615.2980549987406 616.7558589987457 616.7622480001301 616.9269609991461 617.1480310000479 617.9385580010712 618.3099360000342 618.606119999662 618.6428629998118 618.7280679997057 618.7906499989331 618.8735760003328 619.0870369989425 620.3516440000385 620.9922290015966 621.1925860010087 622.2444659993052 622.277627998963 622.3660489991307 622.418008999899 625.1496989987791 625.1623539999127 627.1784669999033 627.277262000367 627.9604090005159 629.4375409986824 630.2449549995363 630.4929200001061 631.0788170006126 631.1358240004629 632.2119549997151 632.87915099971 635.1096199993044 635.4030349999666 635.7284350004047 635.7706710007042 636.9150390010327 639.5941160004586 640.2295340001583 640.4553219992667 640.641642998904 641.407267998904 643.7297370005399 644.0198980011046 649.7550459988415 651.3937989994884 652.3094490002841 652.9977219998837 653.7803949993104 655.1462000012398 656.4419360011816 656.8092859983444 657.5514319986105 658.7632650006562 659.3713380005211 659.7748220004141 660.152668999508 665.5173749998212 671.0834559984505 675.8278000000864 681.1215419992805 681.3377689998597 685.6072179991752 687.6291910000145 699.5427250005305 700.2594820000231 703.4053959995508 705.0085049998015 707.1040860004723 709.0147710014135
App start nativeLaunch Baseline
Mean: 21.596 ms
Stdev: 3.042 ms (14.1%)
Runs: 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 23 23 24 24 24 24 24 24 25 26 26 26 26 27 27 28 28 29 30 30 30 30

Current
Mean: 22.356 ms
Stdev: 2.738 ms (12.2%)
Runs: 18 18 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 25 26 26 26 26 27 27 27 28 28 28 29 29 29 30
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (7.5%)
Runs: 0.01200300082564354 0.01245100051164627 0.013020999729633331 0.013182999566197395 0.013224000111222267 0.013305999338626862 0.013305999338626862 0.013346999883651733 0.01355000026524067 0.01355000026524067 0.01355000026524067 0.013591000810265541 0.013630999252200127 0.013631001114845276 0.013752998784184456 0.013753000646829605 0.013754000887274742 0.013793999329209328 0.013793999329209328 0.013833999633789062 0.0138349998742342 0.0138349998742342 0.013875000178813934 0.013916000723838806 0.013996999710798264 0.014038000255823135 0.01407800056040287 0.01407800056040287 0.014078998938202858 0.014079000800848007 0.014079000800848007 0.014118999242782593 0.01411999948322773 0.0142000000923872 0.014201000332832336 0.014281999319791794 0.014282001182436943 0.01428299956023693 0.014322999864816666 0.0143630001693964 0.014364000409841537 0.014364000409841537 0.014404000714421272 0.014445001259446144 0.014445001259446144 0.014485999941825867 0.014485999941825867 0.014485999941825867 0.014526000246405602 0.014526000246405602 0.014567000791430473 0.014607999473810196 0.014608001336455345 0.014689000323414803 0.01477000117301941 0.014771001413464546 0.014812000095844269 0.014852000400424004 0.014892999082803726 0.014932999387383461 0.014933999627828598 0.014933999627828598 0.014934001490473747 0.014973999932408333 0.01505499891936779 0.015137000009417534 0.015298999845981598 0.015421999618411064 0.015463000163435936 0.015583999454975128 0.015584001317620277 0.015584001317620277 0.015665998682379723 0.015665998682379723 0.0157880000770092 0.0157880000770092 0.015949999913573265 0.016154000535607338 0.016154000535607338 0.016154000535607338 0.016194000840187073 0.01668200083076954 0.0168869998306036 0.017090000212192535 0.017211999744176865 0.017659001052379608 0.01782199926674366

Current
Mean: 0.017 ms
Stdev: 0.002 ms (12.2%)
Runs: 0.013591000810265541 0.014038000255823135 0.014118999242782593 0.014201000332832336 0.0143630001693964 0.014526000246405602 0.014566998928785324 0.014607999473810196 0.014607999473810196 0.01469000056385994 0.014730000868439674 0.014973999932408333 0.015096999704837799 0.015177000313997269 0.015217998996376991 0.015298999845981598 0.015299001708626747 0.015380000695586205 0.015381000936031342 0.015420999377965927 0.015421999618411064 0.015421999618411064 0.015502998605370522 0.01550300046801567 0.015584999695420265 0.015625 0.015625 0.015665998682379723 0.015666000545024872 0.015705998986959457 0.015786999836564064 0.015949999913573265 0.015950998291373253 0.015951000154018402 0.015991000458598137 0.015991998836398125 0.01603200100362301 0.01603200100362301 0.016072001308202744 0.016114000231027603 0.016154000535607338 0.016154000535607338 0.01619499921798706 0.01619500108063221 0.01631700061261654 0.016439000144600868 0.016479000449180603 0.016519999131560326 0.016600999981164932 0.01660200022161007 0.016642000526189804 0.0167239997535944 0.0167239997535944 0.016927000135183334 0.016968000680208206 0.01700800098478794 0.017009001225233078 0.017211999744176865 0.01737399958074093 0.017455998808145523 0.017618998885154724 0.01769999973475933 0.01769999973475933 0.01798499934375286 0.018025999888777733 0.01810700073838234 0.01826999895274639 0.01855499856173992 0.018594998866319656 0.018758000805974007 0.01892099902033806 0.019165998324751854 0.019408999010920525 0.019491000100970268 0.019693998619914055 0.01977499946951866 0.019977999851107597 0.019979000091552734 0.019979000091552734 0.02018200047314167 0.020304998382925987 0.020386001095175743 0.0204670000821352 0.020671000704169273 0.02087400108575821 0.021402999758720398 0.021524999290704727 0.02172900177538395 0.022746000438928604

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify OSBotify mentioned this pull request Oct 9, 2023
Closed
64 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.80-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Oct 11, 2023
Closed
Closed
@OSBotify OSBotify mentioned this pull request Oct 11, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

2 similar comments
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@situchan situchan situchan approved these changes

Assignees
No one assigned
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkhutornyi @situchan @OSBotify @neil-marcellini